Hide correction fields for closed questions

README.md

@@ -30,6 +30,6 @@ Szkielet komponentu Joomla 6 do gromadzenia pytań testowych.
 
 ## Instalacja
 
-W Joomla wybierz **System → Install → Install from Folder** i wskaż ten katalog. Manifestem instalacyjnym jest `com_testquestions.xml` (wersja 1.42.9).
+W Joomla wybierz **System → Install → Install from Folder** i wskaż ten katalog. Manifestem instalacyjnym jest `com_testquestions.xml` (wersja 1.43.2).
 
 Po instalacji komponent jest dostępny w panelu administratora jako **Pytania testowe**.

administrator/components/com_testquestions/language/en-GB/com_testquestions.ini

@@ -69,6 +69,10 @@ COM_TESTQUESTIONS_AI_SETTINGS_MENU="Konfiguracja AI"
 COM_TESTQUESTIONS_AI_SETTINGS_SAVED="Ustawienia AI zapisano."
 COM_TESTQUESTIONS_AI_SAVE_FAILED="Nie udało się zapisać ustawień AI."
 COM_TESTQUESTIONS_AI_PROVIDER_INVALID="Wybierz prawidłowego dostawcę AI."
+COM_TESTQUESTIONS_AI_EVALUATE_ALL="AI — oceń wszystkie niezaliczone pytania otwarte (%s)"
+COM_TESTQUESTIONS_AI_BULK_DONE="AI oceniło %s pytań."
+COM_TESTQUESTIONS_AI_BULK_PARTIAL="AI oceniło %s pytań; nie udało się ocenić %s. Błąd: %s"
+COM_TESTQUESTIONS_AI_NO_OPEN_QUESTIONS="Brak niezaliczonych pytań otwartych do oceny AI."
 COM_TESTQUESTIONS_AI_EVALUATE="AI"
 COM_TESTQUESTIONS_AI_RESULT="Ocena AI"
 COM_TESTQUESTIONS_AI_NOT_CONFIGURED="Skonfiguruj dostawcę i klucz API w ustawieniach komponentu."

administrator/components/com_testquestions/sql/updates/mysql/1.43.0.sql

@@ -0,0 +1 @@
+-- No database changes required for version 1.43.0.

administrator/components/com_testquestions/sql/updates/mysql/1.43.1.sql

@@ -0,0 +1 @@
+-- No database changes required for version 1.43.1.

administrator/components/com_testquestions/sql/updates/mysql/1.43.2.sql

@@ -0,0 +1 @@
+-- No database changes required for version 1.43.2.

administrator/components/com_testquestions/src/Controller/ResultController.php

@@ -63,6 +63,47 @@ class ResultController extends BaseController
         );
     }
 
+    public function aiAll(): void
+    {
+        if (!Session::checkToken()) {
+            throw new \RuntimeException(Text::_('JINVALID_TOKEN'), 403);
+        }
+
+        $input = Factory::getApplication()->getInput();
+        $id = $input->post->getInt('id');
+        $message = '';
+        $type = 'message';
+
+        try {
+            $summary = $this->getModel('Result')->evaluateAllWithAi($id);
+            if ($summary['failed'] > 0) {
+                $message = Text::sprintf(
+                    'COM_TESTQUESTIONS_AI_BULK_PARTIAL',
+                    $summary['evaluated'],
+                    $summary['failed'],
+                    $summary['first_error']
+                );
+                $type = 'warning';
+            } else {
+                $message = Text::sprintf('COM_TESTQUESTIONS_AI_BULK_DONE', $summary['evaluated']);
+            }
+        } catch (\Throwable $error) {
+            $errorMessage = $error->getMessage();
+            $message = $errorMessage === 'AI_NO_OPEN_QUESTIONS'
+                ? Text::_('COM_TESTQUESTIONS_AI_NO_OPEN_QUESTIONS')
+                : ($errorMessage === 'AI_NOT_CONFIGURED'
+                    ? Text::_('COM_TESTQUESTIONS_AI_NOT_CONFIGURED')
+                    : Text::sprintf('COM_TESTQUESTIONS_AI_ERROR', $errorMessage));
+            $type = 'error';
+        }
+
+        $this->setRedirect(
+            Route::_('index.php?option=com_testquestions&view=result&id=' . $id, false),
+            $message,
+            $type
+        );
+    }
+
     private function saveAssessment(): void
     {
         if (!Session::checkToken()) {

administrator/components/com_testquestions/src/Model/ResultModel.php

@@ -132,25 +132,80 @@ class ResultModel extends BaseDatabaseModel
             );
         }
 
-        $feedback = (new AiService())->evaluate(
+        $aiResult = (new AiService())->evaluate(
             $provider,
             $apiKey,
             strip_tags((string) $question->question),
             (string) ($answer['selected'] ?? ''),
-            (string) $question->answer_open
+            (string) $question->answer_open,
+            (int) $question->points
         );
-        $item->answers[$questionId]['ai_feedback'] = $feedback;
+        $item->answers[$questionId]['ai_feedback'] = $aiResult['feedback'];
+        $item->answers[$questionId]['awarded_points'] = $aiResult['awarded_points'];
+
+        $correctionPoints = 0;
+        foreach ($item->answers as $savedAnswer) {
+            $correctionPoints += (int) ($savedAnswer['awarded_points'] ?? 0);
+        }
 
         $db = Factory::getContainer()->get('DatabaseDriver');
         $row = (object) [
             'id' => $id,
             'answers' => json_encode($item->answers, JSON_UNESCAPED_UNICODE),
+            'points_after' => (int) $item->points_before + $correctionPoints,
         ];
 
         if (!$db->updateObject('#__testquestions_results', $row, 'id')) {
             throw new \RuntimeException('Nie udało się zapisać oceny AI.');
         }
 
-        return $feedback;
+        return $aiResult['feedback'];
+    }
+
+    public function evaluateAllWithAi(int $id): array
+    {
+        $item = $this->getItem($id);
+
+        if (!$item) {
+            throw new \RuntimeException('Nie znaleziono zapisanego testu.');
+        }
+
+        $questionIds = [];
+        foreach ($item->answers as $questionId => $answer) {
+            $question = $item->questions[(int) $questionId] ?? null;
+            if ($question && $question->question_type === 'open' && empty($answer['correct'])) {
+                $questionIds[] = (int) $questionId;
+            }
+        }
+
+        if (!$questionIds) {
+            throw new \RuntimeException('AI_NO_OPEN_QUESTIONS');
+        }
+
+        $evaluated = 0;
+        $failed = 0;
+        $firstError = '';
+
+        foreach ($questionIds as $questionId) {
+            try {
+                $this->evaluateWithAi($id, $questionId);
+                $evaluated++;
+            } catch (\Throwable $error) {
+                $failed++;
+                $firstError = $firstError ?: $error->getMessage();
+
+                if (in_array($error->getMessage(), ['AI_NOT_CONFIGURED'], true)
+                    || str_starts_with($error->getMessage(), 'AI_KEY_EMPTY|')) {
+                    break;
+                }
+            }
+        }
+
+        return [
+            'evaluated' => $evaluated,
+            'failed' => $failed,
+            'first_error' => $firstError,
+            'total' => count($questionIds),
+        ];
     }
 }

administrator/components/com_testquestions/src/Service/AiService.php

@@ -8,7 +8,7 @@ use Joomla\CMS\Http\HttpFactory;
 
 class AiService
 {
-    public function evaluate(string $provider, string $apiKey, string $question, string $answer, string $pattern): string
+    public function evaluate(string $provider, string $apiKey, string $question, string $answer, string $pattern, int $maxPoints): array
     {
         $provider = strtolower(trim($provider));
         $provider = preg_replace('/[^a-z]/', '', $provider);
@@ -24,11 +24,13 @@ class AiService
             throw new \RuntimeException('Nieprawidłowy dostawca AI: ' . $provider);
         }
 
-        $input = "Oceń odpowiedź ucznia na pytanie otwarte.\n\n"
+        $input = "Oceń odpowiedź ucznia na pytanie otwarte i ustal liczbę uznanych punktów.\n"
+            . "Maksymalna liczba punktów za to pytanie: " . max(0, $maxPoints) . ".\n"
+            . "Przyznaj liczbę całkowitą od 0 do maksymalnej liczby punktów. Przyznaj punkty proporcjonalnie za poprawne elementy odpowiedzi; pełne punkty za komplet, część punktów za częściową odpowiedź. Nie przekraczaj limitu.\n\n"
             . "Pytanie:\n" . $question . "\n\n"
             . "Wzorzec odpowiedzi:\n" . $pattern . "\n\n"
             . "Odpowiedź ucznia:\n" . ($answer !== '' ? $answer : 'Brak odpowiedzi') . "\n\n"
-            . "Napisz po polsku krótką ocenę: czy odpowiedź może zostać uznana za poprawną, jakie elementy są poprawne lub błędne oraz czy warto przyznać punkty. Nie zmieniaj wzorca odpowiedzi.";
+            . "Zwróć wyłącznie poprawny obiekt JSON w formacie {\"awarded_points\": liczba_całkowita, \"feedback\": \"krótka ocena po polsku\"}. W ocenie opisz poprawne i brakujące elementy. Nie zmieniaj wzorca odpowiedzi.";
 
         $payload = json_encode([
             'model' => $config['model'],
@@ -56,7 +58,25 @@ class AiService
             throw new \RuntimeException('Brak treści odpowiedzi AI.');
         }
 
-        return $text;
+        $jsonText = preg_replace('/^```(?:json)?\s*|\s*```$/i', '', trim($text));
+        $result = json_decode($jsonText, true);
+
+        if (!is_array($result) || !isset($result['awarded_points']) || !is_numeric($result['awarded_points'])) {
+            $start = strpos($jsonText, '{');
+            $end = strrpos($jsonText, '}');
+            if ($start !== false && $end !== false && $end > $start) {
+                $result = json_decode(substr($jsonText, $start, $end - $start + 1), true);
+            }
+        }
+
+        if (!is_array($result) || !isset($result['awarded_points']) || !is_numeric($result['awarded_points'])) {
+            throw new \RuntimeException('AI zwróciło nieprawidłowy format oceny i punktów.');
+        }
+
+        return [
+            'awarded_points' => min(max(0, $maxPoints), max(0, (int) $result['awarded_points'])),
+            'feedback' => trim((string) ($result['feedback'] ?? '')),
+        ];
     }
 
     private function extractText(array $body): string

administrator/components/com_testquestions/tmpl/result/default.php

@@ -25,6 +25,18 @@
         <dd class="col-sm-9"><?php echo floor((int) $this->item->execution_time / 60); ?>:<?php echo str_pad((string) ((int) $this->item->execution_time % 60), 2, '0', STR_PAD_LEFT); ?></dd>
     </dl>
     <form action="<?php echo Route::_('index.php?option=com_testquestions&view=result&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="adminForm">
+    <?php $pendingAiCount = 0; ?>
+    <?php foreach ($this->item->answers as $questionId => $answer) : ?>
+        <?php $candidate = $this->item->questions[(int) $questionId] ?? null; ?>
+        <?php if ($candidate && $candidate->question_type === 'open' && empty($answer['correct'])) { $pendingAiCount++; } ?>
+    <?php endforeach; ?>
+    <?php if ($pendingAiCount > 0) : ?>
+        <div class="mb-3">
+            <button type="submit" class="btn btn-primary" formaction="<?php echo Route::_('index.php?option=com_testquestions&task=result.aiAll&id=' . (int) $this->item->id); ?>" onclick="this.form.task.value='result.aiAll';">
+                <?php echo \Joomla\CMS\Language\Text::sprintf('COM_TESTQUESTIONS_AI_EVALUATE_ALL', $pendingAiCount); ?>
+            </button>
+        </div>
+    <?php endif; ?>
     <h2><?php echo \Joomla\CMS\Language\Text::_('COM_TESTQUESTIONS_RESULT_ANSWERS'); ?></h2>
     <?php foreach ($this->item->answers as $questionId => $answer) : ?>
         <?php $question = $this->item->questions[(int) $questionId] ?? null; if (!$question) continue; ?>
@@ -48,6 +60,7 @@
                         <div class="alert alert-info mt-3"><strong><?php echo \Joomla\CMS\Language\Text::_('COM_TESTQUESTIONS_AI_RESULT'); ?>:</strong><br><?php echo nl2br(htmlspecialchars((string) $answer['ai_feedback'], ENT_QUOTES, 'UTF-8')); ?></div>
                     <?php endif; ?>
                 <?php endif; ?>
+                <?php if ($question->question_type === 'open') : ?>
                     <div class="row mt-3">
                         <div class="col-md-3">
                             <label for="awarded-points-<?php echo (int) $questionId; ?>" class="form-label"><?php echo \Joomla\CMS\Language\Text::sprintf('COM_TESTQUESTIONS_RESULT_AWARDED_POINTS', (int) ($question->points ?? 0)); ?></label>
@@ -59,6 +72,7 @@
                         </div>
                     </div>
                 <?php endif; ?>
+            <?php endif; ?>
         </article>
     <?php endforeach; ?>
     <input type="hidden" name="task" value="result.save">

com_testquestions.xml

@@ -4,7 +4,7 @@
     <creationDate>2026-10-14</creationDate>
     <author>Komponent</author>
     <license>GNU General Public License version 2 or later</license>
-    <version>1.42.9</version>
+    <version>1.43.2</version>
     <description>COM_TESTQUESTIONS_DESCRIPTION</description>
     <element>com_testquestions</element>
     <namespace path="src">Komponent\Component\Testquestions</namespace>